Re: [PATCH] hwmon: Remove strlcpy occurences

From: Azeem Shaikh
Date: Wed Jul 12 2023 - 15:26:08 EST


On Wed, Jul 12, 2023 at 2:04 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Wed, Jul 12, 2023 at 08:16:39AM -0700, Guenter Roeck wrote:
> > On 7/12/23 07:44, Azeem Shaikh wrote:
> > > [...]
> > > + len = strlen(result);
> > > return simple_read_from_buffer(buf, count, ppos, tbuf, len);
> >
> > This still copies tbuf, meaning all those constant strings won't actually
> > be reported.
>
> Ah dang, thanks for catching that. Yeah, "tbuf" should be replaced by
> "result" in the simple_read_from_buffer().
>

Thanks for review folks, will send out a v2 shortly.