Re: [RFC v2 6/9] kunit: memcpy: Mark tests as slow using test attributes

[Kees Cook]

On July 7, 2023 2:09:44 PM PDT, Rae Moar <rmoar@xxxxxxxxxx> wrote:
>Mark slow memcpy KUnit tests using test attributes.
>
>Tests marked as slow are as follows: memcpy_large_test, memmove_test,
>memmove_large_test, and memmove_overlap_test. These tests were the slowest
>of the memcpy tests and relatively slower to most other KUnit tests. Most
>of these tests are already skipped when CONFIG_MEMCPY_SLOW_KUNIT_TEST is
>not enabled.
>
>These tests can now be filtered using the KUnit test attribute filtering
>feature. Example: --filter "speed>slow". This will run only the tests that
>have speeds faster than slow. The slow attribute will also be outputted in
>KTAP.
>
>Note: This patch is intended to replace the use of
>CONFIG_MEMCPY_SLOW_KUNIT_TEST and to potentially deprecate this feature.
>This patch does not remove the config option but does add a note to the
>config definition commenting on this future shift.
>
>Signed-off-by: Rae Moar <rmoar@xxxxxxxxxx>

I remain excited about this series. :)

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>


-- 
Kees Cook