Re: [PATCH 1/2] dt-bindings: net: fsl,fec: Add TX clock controls

[Vesa Jääskeläinen]

Hi Ahmad,

On 13.7.2023 11.47, Ahmad Fatoum wrote:
> Hello Vesa,
>
> On 13.07.23 10:29, Vesa Jääskeläinen wrote:
> > Hi Krzysztof,
> >
> > On 12.7.2023 23.36, Krzysztof Kozlowski wrote:
> > > On 11/07/2023 17:08, Vesa Jääskeläinen wrote:
> > > > With fsl,fec-tx-clock-output one can control if TX clock is routed outside
> > > > of the chip.
> > > >
> > > > With fsl,fec-tx-clk-as-ref-clock one can select if external TX clock is as
> > > > reference clock.
> > > >
> > > > Signed-off-by: Vesa Jääskeläinen <vesa.jaaskelainen@xxxxxxxxxxx>
> > > > ---
> > > >    .../devicetree/bindings/net/fsl,fec.yaml          | 15 +++++++++++++++
> > > >    1 file changed, 15 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > > index b494e009326e..c09105878bc6 100644
> > > > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > > @@ -166,6 +166,21 @@ properties:
> > > >        description:
> > > >          If present, indicates that the hardware supports waking up via magic packet.
> > > >    +  fsl,fec-tx-clock-output:
> > > > +    $ref: /schemas/types.yaml#/definitions/flag
> > > > +    description:
> > > > +      If present, ENETx_TX_CLK output driver is enabled.
> > > > +      If not present, ENETx_TX_CLK output driver is disabled.
> > > Here...
> > >
> > > > +
> > > > +  fsl,fec-tx-clk-as-ref-clock:
> > > > +    $ref: /schemas/types.yaml#/definitions/flag
> > > > +    description:
> > > > +      If present, gets ENETx TX reference clk from the ENETx_TX_CLK pin. In
> > > > +      this use case, an external OSC provides the clock for both the external
> > > > +      PHY and the internal controller.
> > > > +      If not present, ENETx TX reference clock is driven by ref_enetpllx. This
> > > > +      clock is also output to pins via the IOMUX.ENET_REF_CLKx function.
> > > and here:
> > > In general, Common Clock Framework and its bindings should be used for
> > > handling clock providers and consumers. Why it cannot be used for these
> > > two cases?
> > Did you have something specific in mind on how it could be modeled?
> >
> > I tried to look at:
> > Documentation/devicetree/bindings/clock/
> >
> > But didn't spot anything for this.
> This has been implemented for i.MX6Q/DL using CCF. Please follow suit
> for SoloX. See series at:
> https://lore.kernel.org/all/20230131084642.709385-1-o.rempel@xxxxxxxxxxxxxx/
>
> Thanks,
> Ahmad

Thanks for the reference. This looks promising.

Let me try it out.

Thanks,
Vesa Jääskeläinen