Re: [PATCH net-next v3 08/11] net: phy: add support for C45-over-C22 transfers
From: Simon Horman
Date: Thu Jul 13 2023 - 05:19:48 EST
On Thu, Jul 13, 2023 at 11:00:07AM +0200, Michael Walle wrote:
> Hi Simon,
>
> Am 2023-07-13 10:56, schrieb Simon Horman:
> > On Wed, Jul 12, 2023 at 05:07:08PM +0200, Michael Walle wrote:
> >
> > ...
> >
> > > @@ -780,6 +782,7 @@ static int get_phy_c45_devs_in_pkg(struct
> > > mii_bus *bus, int addr, int dev_addr,
> > > * the "devices in package" is invalid.
> > > */
> > > static int get_phy_c45_ids(struct mii_bus *bus, int addr,
> > > + enum phy_access_mode mode,
> >
> > Please add the new mode parameter to the kernel doc for this function,
> > which is in the lines preceding this hunk.
>
> Ahh. Sorry. You've already mentioned that last time :/
>
> Also true for get_phy_c45_devs_in_pkg().
Thanks, I missed that one today.