RE: [PATCH V5] regulator: da9062: Make the use of IRQ optional
From: Christoph Niedermaier
Date: Thu Jul 13 2023 - 11:37:40 EST
From: Mark Brown [mailto:broonie@xxxxxxxxxx]
Sent: Thursday, July 13, 2023 2:30 PM
> On Thu, Jul 13, 2023 at 11:03:28AM +0200, Christoph Niedermaier wrote:
>
>> This patch makes the use of IRQ optional to make the DA9061/62 usable
>> for designs that don't have the IRQ pin connected, because the regulator
>> is usable without IRQ.
>
> Are there any dependencies for this patch? The fact that I acked it
> makes me think there were MFD parts
It's a patch series. This patch is the last one in this series, that is
missing to have the ability to run the DA9061/62 without a connected IRQ
pin. The other patches are already upstreamed and yes there are MFD parts,
see below:
1: commit 7ef5c57758c4 ("dt-bindings: mfd: da9062: Move IRQ to optional properties")
2: commit 7d61f6313e90 ("mfd: da9062: Use MFD_CELL_OF macro")
3: commit c923d5001ba0 ("mfd: da9062: Remove IRQ requirement")
4: This patch ("regulator: da9062: Make the use of IRQ optional")
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> Link: https://lore.kernel.org/oe-kbuild-all/202303082246.GuLdPL0t-lkp@xxxxxxxxx/
>
> I really doubt that the LKP bot ran into an issue due to a system with
> this device without an IRQ wired up...
In V3 of this patch the kernel test robot found an issue. I had really
overlooked that. Thanks to LKP. I forgot to replace the irq variable in
the function devm_request_threaded_irq(). So it affected the path with
IRQ. In V4 I fixed that. In V5 I only rebased it on the current next
20230713 and add Marek's Reviewed-by tag.
Regards
Christoph