Re: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()

[Jay Vosburgh]

Wang Ming <machel@xxxxxxxx> wrote:

>The debugfs_create_dir() function returns error pointers,
>it never returns NULL. Most incorrect error checks were fixed,
>but the one in bond_create_debugfs() was forgotten.
>
>Fix the remaining error check.
>
>Signed-off-by: Wang Ming <machel@xxxxxxxx>

	Seems fine to me; note that almost nobody uses this as bonding
debugfs is hidden behind !CONFIG_NET_NS.

Acked-by: Jay Vosburgh <jay.vosburgh@xxxxxxxxxxxxx>

	-J

>Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
>index 594094526648..d4a82f276e87 100644
>--- a/drivers/net/bonding/bond_debugfs.c
>+++ b/drivers/net/bonding/bond_debugfs.c
>@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
> {
> 	bonding_debug_root = debugfs_create_dir("bonding", NULL);
> 
>-	if (!bonding_debug_root)
>+	if (IS_ERR(bonding_debug_root))
> 		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
> }
> 
>-- 
>2.25.1
>
>