drivers/gpu/drm/drm_edid.c:6150:13: warning: stack frame size (1472) exceeds limit (1024) in 'drm_parse_cea_ext'
From: kernel test robot
Date: Thu Jul 13 2023 - 13:52:13 EST
Hi Jani,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: eb26cbb1a754ccde5d4d74527dad5ba051808fad
commit: e1e7bc481d49c3e3ada11029ce0d9b85a0a539d7 drm/edid: convert to device specific logging
date: 9 months ago
config: riscv-randconfig-r003-20230713 (https://download.01.org/0day-ci/archive/20230714/202307140130.UtmhoTp8-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20230714/202307140130.UtmhoTp8-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307140130.UtmhoTp8-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/drm_edid.c:6150:13: warning: stack frame size (1472) exceeds limit (1024) in 'drm_parse_cea_ext' [-Wframe-larger-than]
static void drm_parse_cea_ext(struct drm_connector *connector,
^
1 warning generated.
vim +/drm_parse_cea_ext +6150 drivers/gpu/drm/drm_edid.c
2869f599c0d8c9 Philipp Zabel 2022-01-23 6149
1cea146a806ae1 Ville Syrjälä 2016-09-28 @6150 static void drm_parse_cea_ext(struct drm_connector *connector,
e42192b4c345a8 Jani Nikula 2022-05-11 6151 const struct drm_edid *drm_edid)
1cea146a806ae1 Ville Syrjälä 2016-09-28 6152 {
1cea146a806ae1 Ville Syrjälä 2016-09-28 6153 struct drm_display_info *info = &connector->display_info;
8db73897698ccb Jani Nikula 2022-05-05 6154 struct drm_edid_iter edid_iter;
dfc0312596561a Jani Nikula 2022-05-03 6155 const struct cea_db *db;
dfc0312596561a Jani Nikula 2022-05-03 6156 struct cea_db_iter iter;
1cea146a806ae1 Ville Syrjälä 2016-09-28 6157 const u8 *edid_ext;
1cea146a806ae1 Ville Syrjälä 2016-09-28 6158
bbded689680f0f Jani Nikula 2022-05-09 6159 drm_edid_iter_begin(drm_edid, &edid_iter);
8db73897698ccb Jani Nikula 2022-05-05 6160 drm_edid_iter_for_each(edid_ext, &edid_iter) {
8db73897698ccb Jani Nikula 2022-05-05 6161 if (edid_ext[0] != CEA_EXT)
8db73897698ccb Jani Nikula 2022-05-05 6162 continue;
1cea146a806ae1 Ville Syrjälä 2016-09-28 6163
8db73897698ccb Jani Nikula 2022-05-05 6164 if (!info->cea_rev)
1cea146a806ae1 Ville Syrjälä 2016-09-28 6165 info->cea_rev = edid_ext[1];
1cea146a806ae1 Ville Syrjälä 2016-09-28 6166
8db73897698ccb Jani Nikula 2022-05-05 6167 if (info->cea_rev != edid_ext[1])
e1e7bc481d49c3 Jani Nikula 2022-10-24 6168 drm_dbg_kms(connector->dev,
e1e7bc481d49c3 Jani Nikula 2022-10-24 6169 "[CONNECTOR:%d:%s] CEA extension version mismatch %u != %u\n",
e1e7bc481d49c3 Jani Nikula 2022-10-24 6170 connector->base.id, connector->name,
8db73897698ccb Jani Nikula 2022-05-05 6171 info->cea_rev, edid_ext[1]);
7344bad7fb6daa Jani Nikula 2022-03-23 6172
8db73897698ccb Jani Nikula 2022-05-05 6173 /* The existence of a CTA extension should imply RGB support */
8db73897698ccb Jani Nikula 2022-05-05 6174 info->color_formats = DRM_COLOR_FORMAT_RGB444;
1cea146a806ae1 Ville Syrjälä 2016-09-28 6175 if (edid_ext[3] & EDID_CEA_YCRCB444)
c03d0b52ff71d5 Maxime Ripard 2022-01-20 6176 info->color_formats |= DRM_COLOR_FORMAT_YCBCR444;
1cea146a806ae1 Ville Syrjälä 2016-09-28 6177 if (edid_ext[3] & EDID_CEA_YCRCB422)
c03d0b52ff71d5 Maxime Ripard 2022-01-20 6178 info->color_formats |= DRM_COLOR_FORMAT_YCBCR422;
7344bad7fb6daa Jani Nikula 2022-03-23 6179 }
8db73897698ccb Jani Nikula 2022-05-05 6180 drm_edid_iter_end(&edid_iter);
1cea146a806ae1 Ville Syrjälä 2016-09-28 6181
5e87b2e5171621 Jani Nikula 2022-05-09 6182 cea_db_iter_edid_begin(drm_edid, &iter);
dfc0312596561a Jani Nikula 2022-05-03 6183 cea_db_iter_for_each(db, &iter) {
dfc0312596561a Jani Nikula 2022-05-03 6184 /* FIXME: convert parsers to use struct cea_db */
dfc0312596561a Jani Nikula 2022-05-03 6185 const u8 *data = (const u8 *)db;
1cea146a806ae1 Ville Syrjälä 2016-09-28 6186
23ebf8b9eab915 Ville Syrjälä 2016-09-28 6187 if (cea_db_is_hdmi_vsdb(db))
dfc0312596561a Jani Nikula 2022-05-03 6188 drm_parse_hdmi_vsdb_video(connector, data);
be982415fc2e95 Jani Nikula 2022-05-09 6189 else if (cea_db_is_hdmi_forum_vsdb(db) ||
115fcf5899f7e0 Lee Shawn C 2022-05-03 6190 cea_db_is_hdmi_forum_scdb(db))
dfc0312596561a Jani Nikula 2022-05-03 6191 drm_parse_hdmi_forum_scds(connector, data);
be982415fc2e95 Jani Nikula 2022-05-09 6192 else if (cea_db_is_microsoft_vsdb(db))
dfc0312596561a Jani Nikula 2022-05-03 6193 drm_parse_microsoft_vsdb(connector, data);
be982415fc2e95 Jani Nikula 2022-05-09 6194 else if (cea_db_is_y420cmdb(db))
dfc0312596561a Jani Nikula 2022-05-03 6195 drm_parse_y420cmdb_bitmap(connector, data);
be982415fc2e95 Jani Nikula 2022-05-09 6196 else if (cea_db_is_vcdb(db))
dfc0312596561a Jani Nikula 2022-05-03 6197 drm_parse_vcdb(connector, data);
be982415fc2e95 Jani Nikula 2022-05-09 6198 else if (cea_db_is_hdmi_hdr_metadata_block(db))
dfc0312596561a Jani Nikula 2022-05-03 6199 drm_parse_hdr_metadata_block(connector, data);
1cea146a806ae1 Ville Syrjälä 2016-09-28 6200 }
dfc0312596561a Jani Nikula 2022-05-03 6201 cea_db_iter_end(&iter);
d0c94692e0a360 Mario Kleiner 2014-03-27 6202 }
d0c94692e0a360 Mario Kleiner 2014-03-27 6203
:::::: The code at line 6150 was first introduced by commit
:::::: 1cea146a806ae1f34cb1b5e3206ff63a2bb90782 drm/edid: Reduce the number of times we parse the CEA extension block
:::::: TO: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
:::::: CC: Daniel Vetter <daniel.vetter@xxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki