Re: [PATCH] drm/msm/adreno: Fix snapshot BINDLESS_DATA size

[Dmitry Baryshkov]

On 11/07/2023 20:54, Rob Clark wrote:
> From: Rob Clark <robdclark@xxxxxxxxxxxx>
>
> The incorrect size was causing "CP | AHB bus error" when snapshotting
> the GPU state on a6xx gen4 (a660 family).
>
> Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/26
> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>

What about:

Fixes: 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state")

?

> ---
>   drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h
> index 790f55e24533..e788ed72eb0d 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h
> @@ -206,7 +206,7 @@ static const struct a6xx_shader_block {
>   	SHADER(A6XX_SP_LB_3_DATA, 0x800),
>   	SHADER(A6XX_SP_LB_4_DATA, 0x800),
>   	SHADER(A6XX_SP_LB_5_DATA, 0x200),
> -	SHADER(A6XX_SP_CB_BINDLESS_DATA, 0x2000),
> +	SHADER(A6XX_SP_CB_BINDLESS_DATA, 0x800),
>   	SHADER(A6XX_SP_CB_LEGACY_DATA, 0x280),
>   	SHADER(A6XX_SP_UAV_DATA, 0x80),
>   	SHADER(A6XX_SP_INST_TAG, 0x80),

--
With best wishes
Dmitry