[PATCH v4 0/3] erofs-utils: introduce xattr name bloom filter

From: Jingbo Xu
Date: Thu Jul 13 2023 - 22:53:39 EST


changes since v3:
- patch 3: "-Exattr-name-filter" option rather than "--xattr-filter"
option is newly introduced to enable this feature (Gao Xiang)

changes since v2:
- patch 2: introduce xattr_filter_reserved in on-disk superblock;
remove EROFS_XATTR_FILTER_MASK
- patch 3: xattr_filter_reserved is always initialized to 0 by default


changes since RFC:
- the number of hash functions is 1, and now it's implemented as:
xxh32(name, strlen(name), EROFS_XATTR_FILTER_SEED + index),
where the constant magic number EROFS_XATTR_FILTER_SEED [*] is used to
give a better spread for the mapping. (Alexander Larsson)
- fix the value of EROFS_FEATURE_COMPAT_XATTR_FILTER; rename
EROFS_XATTR_BLOOM_* to EROFS_XATTR_FILTER_* (Gao Xiang)


RFC: https://lore.kernel.org/all/20230621083939.128961-1-jefflexu@xxxxxxxxxxxxxxxxx/
v2: https://lore.kernel.org/all/20230705071017.104130-1-jefflexu@xxxxxxxxxxxxxxxxx/
v3: https://lore.kernel.org/all/20230712121331.99671-1-jefflexu@xxxxxxxxxxxxxxxxx/

The xattr bloom filter feature is used to boost the negative xattr
lookup.

Refer to the kernel patch set [*] for more details.

[*] https://lore.kernel.org/all/20230705070427.92579-1-jefflexu@xxxxxxxxxxxxxxxxx/


Jingbo Xu (3):
erofs-utils: add xxh32 library
erofs-utils: update on-disk format for xattr name filter
erofs-utils: mkfs: enable xattr name filter

include/erofs/config.h | 1 +
include/erofs/internal.h | 1 +
include/erofs/xxhash.h | 35 +++++++++++++++++
include/erofs_fs.h | 12 +++++-
lib/Makefile.am | 3 +-
lib/xattr.c | 74 ++++++++++++++++++++++++++--------
lib/xxhash.c | 85 ++++++++++++++++++++++++++++++++++++++++
mkfs/main.c | 7 ++++
8 files changed, 199 insertions(+), 19 deletions(-)
create mode 100644 include/erofs/xxhash.h
create mode 100644 lib/xxhash.c

--
2.19.1.6.gb485710b