Re: [PATCH v5] wifi: ath5k: remove phydir check from ath5k_debug_init_device()

[Jiri Slaby]

On 14. 07. 23, 9:10, Minjie Du wrote:
> 'phydir' returned from debugfs_create_dir() is checked against NULL.
> As the debugfs API returns an error pointer,
> the returned value can never be NULL.
>
> Therefore, as the documentation suggests that the check is unnecessary
> and other debugfs calls have no operation in error cases,
> it is advisable to completely eliminate the check.
>
> Signed-off-by: Minjie Du <duminjie@xxxxxxxx>

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

thanks,
--
js
suse labs