Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF register

From: Andy Shevchenko
Date: Fri Jul 14 2023 - 08:31:56 EST


On Fri, Jul 14, 2023 at 03:07:42PM +0300, Ilpo Järvinen wrote:
> On Thu, 13 Jul 2023, Ruihong Luo wrote:
>
> > Preserve the original value of the Divisor Latch Fraction (DLF) register.
> > When the DLF register is modified without preservation, it can disrupt
> > the baudrate settings established by firmware or bootloader, leading to
> > data corruption and the generation of unreadable or distorted characters.
> >
> > Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")

> You forgot to add:
>
> Cc: stable@xxxxxxxxxxxxxxx

It's there. Just not in the commit message. It's fine.

> > Signed-off-by: Ruihong Luo <colorsu1922@xxxxxxxxx>
>
> Other than that,
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko