Re: [PATCH v3 03/15] ASoC: SOF: Remove unused Broxton PCI ID

From: Andy Shevchenko
Date: Fri Jul 14 2023 - 08:46:48 EST


On Fri, Jul 14, 2023 at 02:44:06PM +0200, Amadeusz Sławiński wrote:
> On 7/14/2023 2:35 PM, Andy Shevchenko wrote:
> > On Fri, Jul 14, 2023 at 10:24:45PM +0200, Amadeusz Sławiński wrote:

...

> > > sound/hda/intel-dsp-config.c | 7 -------
> > > sound/soc/sof/intel/pci-apl.c | 2 --
> >
> > I dunno how SOF and HDA are related to each other, but in the next patch you
> > also do something about HDA, either group all of them, or split HDA, or split
> > on per file basis. I'm not familiar with the relationship between them up to
> > you which way you choose.
> >
>
> Well SOF is a DSP driver, so that's why I split it from HDA -
> intel-dsp-config.c file is used to perform checks to know if it should load
> DSP driver (and which one), hence the "weird" split.

Ah, okay that explains!

--
With Best Regards,
Andy Shevchenko