Re: [PATCH v1] mm/hwpoison: rename hwp_walk* to hwpoison_walk*
From: Naoya Horiguchi
Date: Sat Jul 15 2023 - 00:07:31 EST
On Thu, Jul 13, 2023 at 11:55:53PM +0000, Jiaqi Yan wrote:
> In the discussion of "Improve hugetlbfs read on HWPOISON hugepages",
> Matthew Wilcox suggests hwp is a bad abbreviation of hwpoison, as hwp
> is already used as "an acronym by acpi, intel_pstate, some clock
> drivers, an ethernet driver, and a scsi driver"[1].
>
> So rename hwp_walk and hwp_walk_ops to hwpoison_walk and
> hwpoison_walk_ops respectively.
>
> raw_hwp_(page|list), *_raw_hwp, and raw_hwp_unreliable flag are other
> major appearances of "hwp". However, given the "raw" hint in the name,
> it is easy to differentiate them from other "hwp" acronyms. Since
> renaming them is not as straightforward as renaming hwp_walk*, they
> are not covered by this commit.
>
> [1] https://lore.kernel.org/lkml/20230707201904.953262-5-jiaqiyan@xxxxxxxxxx/T/#me6fecb8ce1ad4d5769199c9e162a44bc88f7bdec
>
> Signed-off-by: Jiaqi Yan <jiaqiyan@xxxxxxxxxx>
Looks good to me. Thank you.
Acked-by: Naoya Horiguchi <naoya.horiguchi@xxxxxxx>