Re: [PATCH v2 1/6] net: phy: at803x: support qca8081 genphy_c45_pma_read_abilities

From: Jie Luo
Date: Sat Jul 15 2023 - 10:50:03 EST




On 7/14/2023 6:44 PM, Russell King (Oracle) wrote:
On Fri, Jul 14, 2023 at 02:31:31PM +0800, Luo Jie wrote:
qca8081 PHY supports to use genphy_c45_pma_read_abilities for
getting the PHY features supported except for the autoneg ability

but autoneg ability exists in MII_BMSR instead of MMD7.1, add it

When talking about clause 45 PHYs, they don't have a BMSR. The
correct definition is MDIO_STAT1, or "status 1 register".

Apart from that,

Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks!


Thanks Russell for the review, i will update this comment in the next patch set.