[PATCH] sparc: kernel: add missing put_device()
From: sunran001
Date: Tue Jul 18 2023 - 03:26:45 EST
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.
Detected by coccinelle with the following ERRORS:
./arch/sparc/kernel/pci_psycho.c:308:2-8: ERROR: missing put_device;
call of_find_device_by_node on line 290, but without a corresponding
object release within this function.
./arch/sparc/kernel/pci_psycho.c:350:0-1: ERROR: missing put_device;
call of_find_device_by_node on line 290, but without a corresponding
object release within this function.
Signed-off-by: Ran Sun <sunran001@xxxxxxxxxx>
---
arch/sparc/kernel/pci_psycho.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/kernel/pci_psycho.c
b/arch/sparc/kernel/pci_psycho.c
index f413371da387..45f8370bbfad 100644
--- a/arch/sparc/kernel/pci_psycho.c
+++ b/arch/sparc/kernel/pci_psycho.c
@@ -305,6 +305,7 @@ static void psycho_register_error_handlers(struct
pci_pbm_info *pbm)
*/
if (op->archdata.num_irqs < 6)
+ put_device(op->dev);
return;
/* We really mean to ignore the return result here. Two
@@ -347,6 +348,7 @@ static void psycho_register_error_handlers(struct
pci_pbm_info *pbm)
PSYCHO_PCICTRL_EEN);
tmp &= ~(PSYCHO_PCICTRL_SBH_INT);
upa_writeq(tmp, base + PSYCHO_PCIB_CTRL);
+ put_device(op->dev);
}
/* PSYCHO boot time probing and initialization. */