Re: [patch 54/58] x86/xen/apic: Mark apic __ro_after_init

[Juergen Gross]

On 18.07.23 01:15, Thomas Gleixner wrote:
> Nothing can change it post init.
>
> While at it mop up the whitespace damage which causes eyebleed due to an
> editor which is highlighting it.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>
> ---
>   arch/x86/xen/apic.c |   24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)
>
> --- a/arch/x86/xen/apic.c
> +++ b/arch/x86/xen/apic.c
> @@ -123,9 +123,9 @@ static int xen_cpu_present_to_apicid(int
>   		return BAD_APICID;
>   }
>   
> -static struct apic xen_pv_apic = {
> -	.name 				= "Xen PV",
> -	.probe 				= xen_apic_probe_pv,
> +static struct apic xen_pv_apic __ro_after_init = {
> +	.name				= "Xen PV",
> +	.probe				= xen_apic_probe_pv,
>   	.acpi_madt_oem_check		= xen_madt_oem_check,
>   
>   	/* .delivery_mode and .dest_mode_logical not used by XENPV */
> @@ -138,24 +138,24 @@ static struct apic xen_pv_apic = {

One additional note: you could drop initializing .check_apicid_used and
.ioapic_phys_id_map in xen_pv_apic as well, as those are 32-bit only, too.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature