Re: [PATCH] serial: core: Fix serial core port id to not use port->line

From: Tony Lindgren
Date: Wed Jul 19 2023 - 01:50:38 EST


* Jiri Slaby <jirislaby@xxxxxxxxxx> [230719 05:37]:
> On 19. 07. 23, 7:34, Andy Shevchenko wrote:
> > On Wed, Jul 19, 2023 at 07:26:41AM +0200, Jiri Slaby wrote:
> > > On 19. 07. 23, 7:12, Tony Lindgren wrote:
> >
> > ...
> >
> > > > int ctrl_id; /* optional serial core controller id */
> > > > + int port_id; /* optional serial core port id */
> > >
> > > Can the id be negative? If not, please use uint.
> >
> > Does this suggestion apply to ctrl_id as well?
>
> Sure, but he hasn't added it in this series ;). So it should go to someone's
> todo :P.

Yes it can be uint, that's left over from some earlier revision where -ENODEV
was used, will fix that too.

Regards,

Tony