Re: [PATCH 1/3] arm64: dts: mediatek: mt6795: Add support for display blocks and DPI/DSI

[AngeloGioacchino Del Regno]

Il 20/07/23 14:01, Krzysztof Kozlowski ha scritto:
> On 20/07/2023 13:52, AngeloGioacchino Del Regno wrote:
> > Il 20/07/23 13:35, Alexandre Mergnat ha scritto:
> > > On 20/07/2023 11:15, AngeloGioacchino Del Regno wrote:
> > > > Introduce all nodes for all of the display blocks in the MediaTek Helio
> > > > X10 MT6795 SoC, including the DSI PHY and DSI/DPI interfaces: those are
> > > > left disabled as usage is board specific.
> > > >
> > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > > ---
> > > >    arch/arm64/boot/dts/mediatek/mt6795.dtsi | 252 +++++++++++++++++++++++
> > > >    1 file changed, 252 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi
> > > > b/arch/arm64/boot/dts/mediatek/mt6795.dtsi
> > > > index 597bce2fed72..d805d7a63024 100644
> > > > --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi
> > > > +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi
> > > > @@ -2,6 +2,9 @@
> > > >    /*
> > > >     * Copyright (c) 2015 MediaTek Inc.
> > > >     * Author: Mars.C <mars.cheng@xxxxxxxxxxxx>
> > > > + *
> > > > + * Copyright (C) 2023 Collabora Ltd.
> > > > + *                    AngeloGioacchino Del Regno
> > > > <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > >
> > > Shouldn't be like this ?
> > >
> > >    * Copyright (c) 2015 MediaTek Inc.
> > >    * Copyright (C) 2023 Collabora Ltd.
> > >    * Authors: Mars.C <mars.cheng@xxxxxxxxxxxx>
> > >    *          AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> >
> > I don't think that there's any rule about this?
> > Also I don't really mind the strings order, but if anyone really does, I can change
> > it....
>
> These have two entirely different meanings. Your patch suggests you hold
> copyrights (which is usually not true if working for employer).

Right. Thank you, I'll send a new version tomorrow :-)

> Best regards,
> Krzysztof