Re: [PATCH 5/7] dt-bindings: interconnect: qcom: Fix and separate out SDM660

From: Krzysztof Kozlowski
Date: Sat Jul 22 2023 - 05:42:06 EST


On 21/07/2023 15:54, Konrad Dybcio wrote:
> Separate out SDM660 icc bindings from the common file and fix the
> clocks description by removing the wrong internal RPM bus clock
> representation that we've been carrying for years.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

...

> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,gcc-sdm660.h>
> + #include <dt-bindings/clock/qcom,mmcc-sdm660.h>
> + #include <dt-bindings/clock/qcom,rpmcc.h>
> +
> + bimc: interconnect@1008000 {
> + compatible = "qcom,sdm660-bimc";
> + reg = <0x01008000 0x78000>;
> + #interconnect-cells = <1>;
> + };
> +
> + cnoc: interconnect@1500000 {
> + compatible = "qcom,sdm660-cnoc";
> + reg = <0x01500000 0x10000>;
> + #interconnect-cells = <1>;
> + };
> +
> + snoc: interconnect@1626000 {
> + compatible = "qcom,sdm660-snoc";
> + reg = <0x01626000 0x7090>;
> + #interconnect-cells = <1>;
> + };
> +
> + a2noc: interconnect@1704000 {
> + compatible = "qcom,sdm660-a2noc";
> + reg = <0x01704000 0xc100>;
> + #interconnect-cells = <1>;
> + clocks = <&rpmcc RPM_SMD_IPA_CLK>,
> + <&gcc GCC_UFS_AXI_CLK>,
> + <&gcc GCC_AGGRE2_UFS_AXI_CLK>,
> + <&gcc GCC_AGGRE2_USB3_AXI_CLK>,
> + <&gcc GCC_CFG_NOC_USB2_AXI_CLK>;
> + clock-names = "ipa",
> + "ufs_axi",
> + "aggre2_ufs_axi",
> + "aggre2_usb3_axi",
> + "cfg_noc_usb2_axi";
> + };

Keep only two examples.

Best regards,
Krzysztof