Re: [PATCH v1 1/1] Revert "um: Use swap() to make code cleaner"

From: Andy Shevchenko
Date: Mon Jul 24 2023 - 10:32:37 EST


On Mon, Jul 24, 2023 at 05:23:07PM +0300, Andy Shevchenko wrote:
> This reverts commit 9b0da3f22307af693be80f5d3a89dc4c7f360a85.
>
> The sigio.h is clearly user space code which is handled by

Should be .c

> arch/um/scripts/Makefile.rules (see USER_OBJS rule).
>
> The above mentioned commit simply broke this agreement,
> we may not use Linux kernel internal headers in them without
> thorough thinking.
>
> Hence, revert the wrong commit.

Missing Reported-by

> Closes: https://lore.kernel.org/oe-kbuild-all/202307212304.cH79zJp1-lkp@xxxxxxxxx/

I have just sent a v2: https://lore.kernel.org/r/20230724143131.30090-1-andriy.shevchenko@xxxxxxxxxxxxxxx.

--
With Best Regards,
Andy Shevchenko