Re: [PATCH v2 4/9] ALSA: hda/i915: Allow xe as match for i915_component_master_match

[Maarten Lankhorst]

Hey,

On 2023-07-24 12:28, Pierre-Louis Bossart wrote:
> On 7/19/23 18:41, Maarten Lankhorst wrote:
> > xe is a new driver for intel GPU's that shares the sound related code
> > with i915.
> >
> > Don't allow it to be modprobed though; the module is not upstream yet
> > and we should exclusively use the EPROBE_DEFER mechanism.
>
> I can't figure out what this comment means.
>
> how would the -EPROBE_DEFER mechanism help if the driver that will
> trigger a new probe is not upstream?
>
> Not following at all what you intended to explain.

What I mean is that there is code inside the current code that does 
request_module("i915"), the comment meant I didn't try to add any logic 
for request_module("xe"), as the driver is not merged yet.

Additionally I am removing the request_module logic, but this comment 
was written when I first tried the simple solution of request_module("xe").

Turns out telepathy is hard, and using -EPROBE_DEFER is much simpler. :-)

Cheers,
~Maarten