[PATCH RESEND v6 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc
From: Raghu Halharvi
Date: Tue Jul 25 2023 - 08:19:58 EST
Issue found with checkpatch
A return of errno should be good enough if the memory allocation fails,
the error message here is redundant as per the coding style, removing
it.
Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
Signed-off-by: Raghu Halharvi <raghuhack78@xxxxxxxxx>
---
drivers/cxl/core/mbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index d6d067fbee97..af7f37cea871 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -1325,10 +1325,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev)
struct cxl_memdev_state *mds;
mds = devm_kzalloc(dev, sizeof(*mds), GFP_KERNEL);
- if (!mds) {
- dev_err(dev, "No memory available\n");
+ if (!mds)
return ERR_PTR(-ENOMEM);
- }
mutex_init(&mds->mbox_mutex);
mutex_init(&mds->event.log_lock);
--
2.39.2