Re: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()

From: Kalle Valo
Date: Tue Jul 25 2023 - 10:45:55 EST


Zhang Shurong <zhang_shurong@xxxxxxxxxxx> wrote:

> If there is a failure during kstrtobool_from_user()
> rtw89_debug_priv_btc_manual_set should return a negative error code
> instead of returning the count directly.
>
> Fix this bug by returning an error code instead of a count after
> a failed call of the function "kstrtobool_from_user". Moreover
> I omitted the label "out" with this source code correction.
>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Zhang Shurong <zhang_shurong@xxxxxxxxxxx>
> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

Patch applied to wireless-next.git, thanks.

59b4cc439f18 wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()

--
https://patchwork.kernel.org/project/linux-wireless/patch/tencent_1C09B99BD7DA9CAD18B00C8F0F050F540607@xxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches