Re: [PATCH v2] sparc: Use shared font data

From: Sam Ravnborg
Date: Tue Jul 25 2023 - 12:11:49 EST


On Tue, Jul 25, 2023 at 12:58:51AM +0100, linux@xxxxxxxxxxx wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> sparc has a 'btext' font used for the console which is almost identical
> to the shared font_sun8x16, so use it rather than duplicating the data.
>
> They were actually identical until about a decade ago when
> commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
> "broken bar" to "vertical line"")
>
> which changed the | in the shared font to be a solid
> bar rather than a broken bar. That's the only difference.
>
> This was originally spotted by PMD which noticed that PPC does
> the same thing with the same data, and they also share a bunch
> of functions to manipulate the data. The PPC code and the functions
> I'll look at another time if this patch is OK.
>
> Tested very lightly with a boot without FS in qemu.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Looks good, thanks for the fixes.
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

Let's hope someone picks it up...

Sam