Re: [PATCH v2 36/61] mmc: sdhci-sprd: Convert to platform remove callback returning void

[Chunyan Zhang]

On Wed, 26 Jul 2023 at 12:02, Yangtao Li <frank.li@xxxxxxxx> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>

Acked-by: Chunyan Zhang <zhang.lyra@xxxxxxxxx>

Thanks,
Chunyan

> ---
>  drivers/mmc/host/sdhci-sprd.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 7f4ee2e12735..379cb3892757 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -720,7 +720,7 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
>         return ret;
>  }
>
> -static int sdhci_sprd_remove(struct platform_device *pdev)
> +static void sdhci_sprd_remove(struct platform_device *pdev)
>  {
>         struct sdhci_host *host = platform_get_drvdata(pdev);
>         struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host);
> @@ -732,8 +732,6 @@ static int sdhci_sprd_remove(struct platform_device *pdev)
>         clk_disable_unprepare(sprd_host->clk_2x_enable);
>
>         sdhci_pltfm_free(pdev);
> -
> -       return 0;
>  }
>
>  static const struct of_device_id sdhci_sprd_of_match[] = {
> @@ -800,7 +798,7 @@ static const struct dev_pm_ops sdhci_sprd_pm_ops = {
>
>  static struct platform_driver sdhci_sprd_driver = {
>         .probe = sdhci_sprd_probe,
> -       .remove = sdhci_sprd_remove,
> +       .remove_new = sdhci_sprd_remove,
>         .driver = {
>                 .name = "sdhci_sprd_r11",
>                 .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> --
> 2.39.0
>