Re: [PATCH net-next v2 1/2] r8152: adjust generic_ocp_write function
From: Andrew Lunn
Date: Wed Jul 26 2023 - 04:45:56 EST
On Wed, Jul 26, 2023 at 11:08:07AM +0800, Hayes Wang wrote:
> Reduce the control transfer if all bytes of first or the last DWORD are
> written.
>
> The original method is to split the control transfer into three parts
> (the first DWORD, middle continuous data, and the last DWORD). However,
> they could be combined if whole bytes of the first DWORD or last DWORD
> are written. That is, the first DWORD or the last DWORD could be combined
> with the middle continuous data, if the byte_en is 0xff.
How often is byte_en 0xff? Do you have some benchmark numbers to show
it is worth the complexity?
Andrew