Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs

From: Rob Herring
Date: Thu Jul 27 2023 - 09:17:06 EST



On Thu, 27 Jul 2023 18:13:33 +0530, Rohit Agarwal wrote:
> Update the RPMHPD references with new bindings defined in rpmhpd.h
> for Qualcomm SoCs SM8[2345]50.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx>
> ---
>
> Changes in v2:
> - Removed the unnecessary inclusion of header rpmpd.h.
>
> This patch is dependent on the series that includes the new rpmhpd.h header
> https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohiagar@xxxxxxxxxxx/
>
> Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++--
> Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++--
> Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 4 ++--
> Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++--
> Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++--
> Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++--
> Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++--
> .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++--
> .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 ++++----
> .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++--
> .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++---
> .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++--
> .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 ++++----
> .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++--
> .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 ++++----
> Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 4 ++--
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++--
> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++---
> 18 files changed, 44 insertions(+), 44 deletions(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory
21 | #include <dt-bindings/power/qcom,rpmhpd.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690461813-22564-1-git-send-email-quic_rohiagar@xxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.