Thomas Zimmermann <tzimmermann@xxxxxxx> writes:
Hello Thomas,
Hi Javier
Am 27.07.23 um 16:04 schrieb Javier Martinez Canillas:
The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's
.atomic_check() callback") moved the buffers allocation to be done in
the primary plane's .atomic_check() callback.
But it missed that since the driver uses a shadow-buffered plane, the
__drm_gem_{reset,duplicate,destroy}_shadow_plane() helper functions
must be used in the struct drm_plane_funcs handlers.
This was missed because the mentioned commit did not remove the macro
DRM_GEM_SHADOW_PLANE_FUNCS, which leads to the custom plane's atomic
state management handlers to not be used.
Fixes: 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback")
Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
Reported-by needs to be followed by
Closes: <url>
where <url> would point to Arnd's bug report on dri-devel.
Ah, I thought checkpatch complaining about it but since we already add a
Link: with dim, didn't know what to add there. Makes sense to add Arnd's
report indeed.
I can include it when applying instead of posting a v2 if you don't mind.
Suggested-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
This looks correct now. Thanks for fixing this bug quickly. With the
Close added:
Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Thanks and to you for pointing that out.
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature