Re: [PATCH drm-misc-next v8 01/12] drm: manager to keep track of GPUs VA mappings

[Boris Brezillon]

On Fri, 28 Jul 2023 13:31:36 +0200
Maxime Ripard <mripard@xxxxxxxxxx> wrote:

> Hi Danilo,
> 
> On Thu, Jul 20, 2023 at 02:14:22AM +0200, Danilo Krummrich wrote:
> > Add infrastructure to keep track of GPU virtual address (VA) mappings
> > with a decicated VA space manager implementation.
> > 
> > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers
> > start implementing, allow userspace applications to request multiple and
> > arbitrary GPU VA mappings of buffer objects. The DRM GPU VA manager is
> > intended to serve the following purposes in this context.
> > 
> > 1) Provide infrastructure to track GPU VA allocations and mappings,
> >    making using an interval tree (RB-tree).
> > 
> > 2) Generically connect GPU VA mappings to their backing buffers, in
> >    particular DRM GEM objects.
> > 
> > 3) Provide a common implementation to perform more complex mapping
> >    operations on the GPU VA space. In particular splitting and merging
> >    of GPU VA mappings, e.g. for intersecting mapping requests or partial
> >    unmap requests.
> > 
> > Acked-by: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>
> > Acked-by: Matthew Brost <matthew.brost@xxxxxxxxx>
> > Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> > Tested-by: Matthew Brost <matthew.brost@xxxxxxxxx>
> > Tested-by: Donald Robson <donald.robson@xxxxxxxxxx>
> > Suggested-by: Dave Airlie <airlied@xxxxxxxxxx>
> > Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>  
> 
> For some reason this breaks the drm_exec kunit patches:

Fix available here [1].

[1]https://lore.kernel.org/dri-devel/cbf4ccf9-8131-27a0-332c-6942866340d1@xxxxxxxxxx/T/#t