Re: [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call

[Bartosz Golaszewski]

On Mon, Jul 17, 2023 at 2:10 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> The platform_set_drvdata() call was never used, ever since the driver was
> originally added.
> It looks like this copy+paste left-over. Possibly the author copied from a
> driver that had this line, but also had a remove hook.
>
> Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>
> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/gpio/gpio-eic-sprd.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index 84352a6f4973..53db88ae2a20 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev)
>                 return ret;
>         }
>
> -       platform_set_drvdata(pdev, sprd_eic);
>         return 0;
>  }
>
> --
> 2.34.1
>

Applied, thanks!

Bart