Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic C3 Reset Controller

From: Zelong Dong
Date: Mon Jul 31 2023 - 05:12:35 EST




在 2023/7/29 0:40, Krzysztof Kozlowski 写道:
On 28/07/2023 17:49, Philipp Zabel wrote:
maxItems: 1
diff --git a/include/dt-bindings/reset/amlogic,c3-reset.h b/include/dt-bindings/reset/amlogic,c3-reset.h
new file mode 100644
index 000000000000..d9127863f603
--- /dev/null
+++ b/include/dt-bindings/reset/amlogic,c3-reset.h

Given that this is only included by
arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi, should this header be
moved to arch/arm64/boot/dts/amlogic ?

I think there is ongoing work or at least plan to use the IDs also in
clock/reset drivers for all Amlogic platforms. Do I recall this correctly?

Best regards,
Krzysztof

So far, Amlogic reset headers are only included by DTS, reset driver will not include these.
Should I move all the headers (include/dt-bindings/reset/amlogic,*.h) to arch/arm64/boot/dts/amlogic ?