Re: [patch V2 50/58] x86/apic: Provide common init infrastructure

From: Thomas Gleixner
Date: Mon Jul 31 2023 - 11:49:07 EST


On Mon, Jul 31 2023 at 15:10, Juergen Gross wrote:
> On 31.07.23 15:01, Thomas Gleixner wrote:
>>> apic_driver(xen_pv_apic);
>>
>> I wonder whether this explicit install is actually needed at all.
>> Shouldn't the driver be installed via the APIC probing mechanism
>> automagically?
>
> Only in case x86_init.irq.intr_mode_init is set appropriately. Today it is
> a nop for Xen PV, but that can be changed. I'll have a look.

You could simply set that callback to default_setup_apic_routing() and
be done with it.