Re: [PATCH 2/2 v10] Watchdog: Add marvell GTI watchdog driver

From: Randy Dunlap
Date: Tue Aug 01 2023 - 00:54:17 EST




On 7/31/23 21:46, Bharat Bhushan wrote:
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index ee97d89dfc11..87ac222b436e 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1797,6 +1797,19 @@ config OCTEON_WDT
> from the first interrupt, it is then only poked when the
> device is written.
>
> +config MARVELL_GTI_WDT
> + tristate "Marvell GTI Watchdog driver"
> + depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> + default y
> + select WATCHDOG_CORE
> + help
> + Marvell GTI hardware supports watchdog timer. First timeout
> + works as watchdog pretimeout and installed interrupt handler
> + will be called on first timeout. Hardware can generate interrupt
> + to SCP on second timeout but it is not enabled, So second

enabled, so second

> + timeout is ignored. If device poke does not happen then system
> + will reboot on third timeout.

All Kconfig help text should be indented with one tab + 2 spaces
according to coding-style.rst.

--
~Randy