Re: [PATCH] USB: gadget: Fix the function name error in sourcesink/loopback.

[chengdong zhou]

On Tue, Aug 1, 2023 at 3:35 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
>
> > > But you changed the name:
> > >
> > > > > > -     ss->function.name = "source/sink";
> > > > > > +     ss->function.name = "sourcesink";
> > >
> > > isn't that visable to userspace?
> >
> > Yes, I removed the "/". Because the macro definition
> > DECLARE_USB_FUNCTION_INIT does not support "/".
> > Should I stick with the original "SourceSink"? I think using the
> > Linux-style "sourcesink" is better. By the way, due to the current
> > bug, no one should be able to use "source/sink" in userspace.
>
> But doesn't the '/' mean that you have a subdirectory here?  What did
> userspace look like before this, and what does it look like now?
>

 Because usb_function.name and usb_function_driver.name are not the
same, this function could not be exported to userspace through the USB
config fs before. Previously, the source/sink was used by g_zero
legacy, so I will make adjustments in the next patch version by
changing the function name to "sourcesink". Do you think this is okay?