Re: [patch V2 50/58] x86/apic: Provide common init infrastructure

[Thomas Gleixner]

On Tue, Aug 01 2023 at 10:25, Juergen Gross wrote:
> On 01.08.23 10:23, Thomas Gleixner wrote:
>> On Tue, Aug 01 2023 at 09:37, Juergen Gross wrote:
>>> On 01.08.23 09:32, Thomas Gleixner wrote:
>>>> On Tue, Aug 01 2023 at 09:08, Juergen Gross wrote:
>>>>> On 01.08.23 08:49, Juergen Gross wrote:
>>>>>     void __init xen_init_apic(void)
>>>>>     {
>>>>>            x86_apic_ops.io_apic_read = xen_io_apic_read;
>>>>> -       /* On PV guests the APIC CPUID bit is disabled so none of the
>>>>> -        * routines end up executing. */
>>>>> -       if (!xen_initial_domain())
>>>>> -               apic_install_driver(&xen_pv_apic);
>>>>> -
>>>>>            x86_platform.apic_post_init = xen_apic_check;
>>>>
>>>> I don't think this one is needed.
>>>
>>> Indeed.
>> 
>> Can you send a real patch please which I can add to that pile at the
>> right place?
>
> I think adding it right after patch 50 should be fine?
>
> The WARN() will be issued only with patch 58.

Correct.