Re: [PATCH v2 20/28] net: wan: Add framer framework support

From: Andrew Lunn
Date: Tue Aug 01 2023 - 05:57:16 EST


> +int framer_pm_runtime_get(struct framer *framer)
> +{
> + int ret;
> +
> + if (!framer)
> + return 0;

Can framer be a NULL pointer? This sort of test often covers up
bugs. So either let it dereference the NULL pointer and opps, or
return -EINVAL.

Andrew