Re: [PATCH v2 21/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

From: Herve Codina
Date: Tue Aug 01 2023 - 06:35:50 EST


On Tue, 1 Aug 2023 12:05:07 +0200
Andrew Lunn <andrew@xxxxxxx> wrote:

> > + clocks:
> > + items:
> > + - description: Master clock
> > + - description: Receive System Clock
> > + - description: Transmit System Clock
> > +
> > + clock-names:
> > + items:
> > + - const: mclk
> > + - const: sclkr
> > + - const: sclkx
>
> Nit pick, but "Receive System Clock", but "sclkr'. Maybe "System Clock
> Receive" so you have the same word order?
>

Will also change the 'Transmit System Clock' to 'System Clock Transmit'

Regards,
Hervé



--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com