Re: [PATCH] nvme: Don't fail to resume if NSIDs change

[Mario Limonciello]

On 8/1/23 06:24, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 03:14:54PM -0500, Limonciello, Mario wrote:
> > > No.  There are tons of NVMe devices that only support creating and
> > > deleting namespace out of band, especially in virtualized and cloud
> > > setups.
> >
> > Even if it's only the error handling path only that it's checked?
>
> Do you mean nvme_validate_ns with the error code?  I wouldn't really call
> that an error case, that's the function called to check namespaces are
> still the same after we did a rescan (either manually or triggered by the
> AEN).
>
> > If you don't want more changes or heuristics on the error handling path for
> > this case, I think the best solution is probably to pick up
> >
> > https://lore.kernel.org/all/20221116171727.4083-1-git@xxxxxxxxxxxxxxxxxx/t/
> >
> > instead then and hopefully we don't end up with more disks like this.
>
> That's probably the better idea.  I know at least one of the early
> quirked devices also IDs that changed for subsequent identify calls.

Do you want that re-sent?  Or can you just pick up from that lore link?