Re: [PATCH v3] usb: common: usb-conn-gpio: Prevent bailing out if initial role is none

From: Prashanth K
Date: Tue Aug 01 2023 - 07:53:29 EST




On 01-08-23 04:31 pm, AngeloGioacchino Del Regno wrote:
Il 01/08/23 11:03, Prashanth K ha scritto:
Currently if we bootup a device without cable connected, then
usb-conn-gpio won't call set_role() because last_role is same
as current role. This happens since last_role gets initialised
to zero during the probe.

To avoid this, add a new flag initial_detection into struct
usb_conn_info, which prevents bailing out during initial
detection.

Cc: <stable@xxxxxxxxxxxxxxx> # 5.4
Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver")
Signed-off-by: Prashanth K <quic_prashk@xxxxxxxxxxx>

Just noticed that there was a v3, sent the T-b to the v2 erroneously, so:

MediaTek platforms

Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>


Thanks AgneloGioacchino for testing.

Regards
Prashanth K