Re: [PATCH v2] tty: vt: Remove some repetitive initialization

[Greg Kroah-Hartman]

On Tue, Aug 01, 2023 at 07:57:24PM +0800, oushixiong wrote:
> 
> Members vc_col???vc_rows and vc_size_row of the struct vc_data have been

Odd ??? characters?

> initialized in visual_init(), so it no longer to initialized them again
> in vc_init().
> 
> v1->v2:
> 	- Fix the comment.

This needs to be below the --- line, right?

> 
> Signed-off-by: oushixiong <oushixiong@xxxxxxxxxx>
> ---
>  drivers/tty/vt/vt.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)

thanks.

greg k-h