Re: [PATCH v2 1/8] iommu/arm-smmu-v3: Move ctx_desc out of s1_cfg
From: Jason Gunthorpe
Date: Tue Aug 01 2023 - 10:08:47 EST
On Mon, Jul 31, 2023 at 06:48:11PM +0800, Michael Shavit wrote:
> s1_cfg describes the CD table that is inserted into an SMMU's STEs. It's
> weird for s1_cfg to also own ctx_desc which describes a CD that is
> inserted into that table. It is more appropriate for arm_smmu_domain to
> own ctx_desc.
>
> Signed-off-by: Michael Shavit <mshavit@xxxxxxxxxx>
> ---
> Changes in v2:
> - Undo over-reaching column alignment change
>
> .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 2 +-
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 23 ++++++++++---------
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 6 +++--
> 3 files changed, 17 insertions(+), 14 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
Jason