Re: [PATCH v2 3/8] iommu/arm-smmu-v3: Encapsulate ctx_desc_cfg init in alloc_cd_tables

[Jason Gunthorpe]

On Mon, Jul 31, 2023 at 06:48:13PM +0800, Michael Shavit wrote:
> This is slighlty cleaner: arm_smmu_ctx_desc_cfg is initialized in a
> single function instead of having pieces set ahead-of time by its caller.
> 
> Signed-off-by: Michael Shavit <mshavit@xxxxxxxxxx>
> ---
> 
> (no changes since v1)
> 
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Yeah, this is the right direction, make a self-contained API around
'struct arm_smmu_ctx_desc_cfg'

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason