Re: [PATCH 0/8] hp-bioscfg: Overall fixes and code cleanup

From: Jorge Lopez
Date: Tue Aug 01 2023 - 11:11:09 EST


Ok. Thanks for the clarification. I will remove 'value_len' and
replace all its references with 'size'.

On Tue, Aug 1, 2023 at 10:04 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> On Tue, Aug 01, 2023 at 09:52:05AM -0500, Jorge Lopez wrote:
> > I will submit a new patch replacing 'value_len' for 'size' in line 267
> > as indicated.
> > 'value_len' is utilized earlier in the code so we cannot remove it
> > completely from the function.
> >
>
> After replacing size then it looks like this.
>
> $ grep value_len drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
> int value_len = 0;
> &str_value, &value_len);
> &str_value, &value_len);
>
> It's a write only variable.
>
> regards,
> dan carpenter
>