Re: [PATCH RFC net-next v5 10/14] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

[Stefano Garzarella]

On Tue, Aug 01, 2023 at 04:30:22AM +0000, Bobby Eshleman wrote:
> On Thu, Jul 27, 2023 at 09:48:21AM +0200, Stefano Garzarella wrote:
> > On Wed, Jul 26, 2023 at 02:38:08PM -0400, Michael S. Tsirkin wrote:
> > > On Wed, Jul 19, 2023 at 12:50:14AM +0000, Bobby Eshleman wrote:
> > > > This commit adds a feature bit for virtio vsock to support datagrams.
> > > >
> > > > Signed-off-by: Jiang Wang <jiang.wang@xxxxxxxxxxxxx>
> > > > Signed-off-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxxxxxx>
> > > > ---
> > > >  include/uapi/linux/virtio_vsock.h | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h
> > > > index 331be28b1d30..27b4b2b8bf13 100644
> > > > --- a/include/uapi/linux/virtio_vsock.h
> > > > +++ b/include/uapi/linux/virtio_vsock.h
> > > > @@ -40,6 +40,7 @@
> > > >
> > > >  /* The feature bitmap for virtio vsock */
> > > >  #define VIRTIO_VSOCK_F_SEQPACKET	1	/* SOCK_SEQPACKET supported */
> > > > +#define VIRTIO_VSOCK_F_DGRAM		3	/* SOCK_DGRAM supported */
> > > >
> > > >  struct virtio_vsock_config {
> > > >  	__le64 guest_cid;
> > >
> > > pls do not add interface without first getting it accepted in the
> > > virtio spec.
> >
> > Yep, fortunatelly this series is still RFC.
> > I think by now we've seen that the implementation is doable, so we
> > should discuss the changes to the specification ASAP. Then we can
> > merge the series.
> >
> > @Bobby can you start the discussion about spec changes?
>
> No problem at all. Am I right to assume that a new patch to the spec is
> the standard starting point for discussion?

Yep, I think so!

Thanks,
Stefano