Re: [PATCH] net: export dev_change_name function

[Jiri Pirko]

Tue, Aug 01, 2023 at 01:21:01PM CEST, quic_ajainp@xxxxxxxxxxx wrote:
>export dev_change_name function to be used by other modules.
>
>Signed-off-by: Vagdhan Kumar <quic_vagdhank@xxxxxxxxxxx>
>Signed-off-by: Anvesh Jain P <quic_ajainp@xxxxxxxxxxx>
>---
> net/core/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 69a3e544676c..1dad68e2950c 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -1254,6 +1254,7 @@ int dev_change_name(struct net_device *dev, const char *newname)
> 
> 	return err;
> }
>+EXPORT_SYMBOL(dev_change_name);
> 
> /**
>  *	dev_set_alias - change ifalias of a device
>
>base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd

nack.
1) there is no in-tree user
2) changing name from anywhere else than userspace does not make any
   sense. I'll eat my shoes if there is a sane reason for it.

Please don't send patches like this.


>-- 
>2.17.1
>