Re: [PATCH v3 11/36] arm64/mm: Map pages for guarded control stack

From: Mark Brown
Date: Tue Aug 01 2023 - 15:05:38 EST


On Tue, Aug 01, 2023 at 08:02:31PM +0300, Mike Rapoport wrote:
> On Mon, Jul 31, 2023 at 02:43:20PM +0100, Mark Brown wrote:

> > {
> > - pteval_t prot = pgprot_val(protection_map[vm_flags &
> > + pteval_t prot;
> > +
> > + /*
> > + * If this is a GCS then only interpret VM_WRITE.
> > + *
> > + * TODO: Just make protection_map[] bigger? Nothing seems
> > + * ideal here.
> > + */

> I think extending protection_map and updating adjust_protection_map() is
> cleaner and probably faster.

That was my initial thought but then I immediately started second
guessing myself about review comments. Hopefully Will or Catalin will
weigh in.

Attachment: signature.asc
Description: PGP signature