Re: [PATCH v2] gpio: lp3943: remove unneeded platform_set_drvdata() call

[Bartosz Golaszewski]

On Tue, Jul 25, 2023 at 12:25 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call, to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>
> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>
> Changelog V1->V2:
> * https://lore.kernel.org/linux-gpio/CAHp75VdU1c1vUoRpbekPXoLg2DDcbSThwUmkdHRT2FaZ9kagRA@xxxxxxxxxxxxxx/T/#t
> * https://lore.kernel.org/linux-gpio/ZLpdOYxo2U+uO%2FH3@xxxxxxxxxxxxxxxxxx/T/#t
> * fixed subject line: adjusted colons where needed
>
>  drivers/gpio/gpio-lp3943.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
> index 79edd5db49d2..8e58242f5123 100644
> --- a/drivers/gpio/gpio-lp3943.c
> +++ b/drivers/gpio/gpio-lp3943.c
> @@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
>         lp3943_gpio->chip = lp3943_gpio_chip;
>         lp3943_gpio->chip.parent = &pdev->dev;
>
> -       platform_set_drvdata(pdev, lp3943_gpio);
> -
>         return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
>                                       lp3943_gpio);
>  }
> --
> 2.34.1
>

Applied, thanks!

Bartosz