Re: [PATCH] arm64: dts: ti: k3-j721s2-main: Add dts nodes for EHRPWMs

From: Nishanth Menon
Date: Tue Aug 01 2023 - 16:12:12 EST


On 13:33-20230801, Nishanth Menon wrote:
> On 17:10-20230713, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@xxxxxx>
> >
> > Add dts nodes for 6 EHRPWM instances on SoC. Disable EHRPWM nodes in the
> > dtsi files and only enable the ones that are actually pinned out on a
> > given board in the board dts file.
> >
> > Signed-off-by: Sinthu Raja <sinthu.raja@xxxxxx>
> > ---
> > arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 66 ++++++++++++++++++++++
> > 1 file changed, 66 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > index ed79ab3a3271..0d3a965f764f 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > @@ -58,6 +58,72 @@ serdes_ln_ctrl: mux-controller@80 {
> > mux-reg-masks = <0x80 0x3>, <0x84 0x3>, /* SERDES0 lane0/1 select */
> > <0x88 0x3>, <0x8c 0x3>; /* SERDES0 lane2/3 select */
> > };
> > +
> > + ehrpwm_tbclk: clock-controller@140 {
> > + compatible = "ti,am654-ehrpwm-tbclk", "syscon";
>
> NAK. Udit: your team needs to please run dtbs_check prior to posting patches
> I had done a cleanup
> https://lore.kernel.org/all/20230713184759.3336536-1-nm@xxxxxx/ already
> and I dont want to reopen this again.
>
> Please read Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
>

Apologies, please ignore my rant. I missed the fact that this was complained about
and addressed in https://lore.kernel.org/all/20230721082150.12599-1-sinthu.raja@xxxxxx/

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D