Re: [PATCH v4 06/29] drm/i915/gvt: Explicitly check that vGPU is attached before shadowing

From: Sean Christopherson
Date: Tue Aug 01 2023 - 19:20:57 EST


On Tue, Aug 01, 2023, Yan Zhao wrote:
> On Fri, Jul 28, 2023 at 06:35:12PM -0700, Sean Christopherson wrote:
> > Move the check that a vGPU is attacked from is_2MB_gtt_possible() all the
> typo: "attacked" --> "attached"
>
> > way up to shadow_ppgtt_mm() to avoid unnecessary work, and to make it more
> This commit message does not match to what the patch does.
> The check in the patch is in ppgtt_populate_shadow_entry().
>
> What you want is like below?

Yeah, I completely botched this and forgot to actually change the code. I'll send
a replacement patch in-reply (or rather, I already sent it; I missed up again and
forgot to hit send on this one earlier in the day...).

Thanks yet again for the review!