Re: [PATCH v3 10/10] ext4: correct some stale comment of criteria

From: Kemeng Shi
Date: Tue Aug 01 2023 - 21:26:09 EST




on 8/2/2023 9:18 AM, Ritesh Harjani wrote:
> Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> writes:
>
>> We named criteria with CR_XXX, correct stale comment to criteria with
>> raw number.
>>
>> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx>
>> ---
>> fs/ext4/mballoc.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>> index bfaab173a3f4..1e8ce0ece47a 100644
>> --- a/fs/ext4/mballoc.c
>> +++ b/fs/ext4/mballoc.c
>> @@ -2782,8 +2782,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
>>
>> /*
>> * ac->ac_2order is set only if the fe_len is a power of 2
>> - * if ac->ac_2order is set we also set criteria to 0 so that we
>> - * try exact allocation using buddy.
>> + * if ac->ac_2order is set we also set criteria to CR_POWER2_ALIGNED
>> + * so that we try exact allocation using buddy.
>> */
>> i = fls(ac->ac_g_ex.fe_len);
>> ac->ac_2order = 0;
>> @@ -2840,8 +2840,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
>> /*
>> * Batch reads of the block allocation bitmaps
>> * to get multiple READs in flight; limit
>> - * prefetching at cr=0/1, otherwise mballoc can
>> - * spend a lot of time loading imperfect groups
>> + * prefetching at inexpensive CR, otherwise mballoc
>> + * can spend a lot of time loading imperfect groups
>> */
>> if ((prefetch_grp == group) &&
>> (ext4_mb_cr_expensive(cr) ||
> Is this function defined at any place ^^^
>
> -ritesh
>
Hi Ritesh, sorry for the bother. I actually menthioned this in v2->v3 change in cover
letter that patch 10 is on top of [1] which has reviewed before.

[1] https://lore.kernel.org/linux-ext4/20230630085927.140137-1-ojaswin@xxxxxxxxxxxxx/
--
Best wishes
Kemeng Shi